fgerlits commented on a change in pull request #958:
URL: https://github.com/apache/nifi-minifi-cpp/pull/958#discussion_r542434970
##########
File path: libminifi/include/controllers/NetworkPrioritizerService.h
##########
@@ -121,6 +126,7 @@ class NetworkPrioritizerService : public
core::controller::ControllerService, pu
bool verify_interfaces_;
private:
+ std::shared_ptr<utils::timeutils::Clock> clock_;
Review comment:
The service and the unit test. If only the service owned it, the unit
test would need to have a naked pointer (or reference) to the clock, and rely
on the order of the operations to make sure it remains valid -- I have
considered this, but did not like it. Since the `clock_` field is only created
once, and never copied, there isn't much of an overhead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
