adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r533971996
##########
File path: libminifi/src/utils/StringUtils.cpp
##########
@@ -31,7 +31,18 @@ bool StringUtils::StringToBool(std::string input, bool
&output) {
return output;
}
-std::string StringUtils::trim(std::string s) {
+utils::optional<bool> StringUtils::toBool(const std::string& str) {
Review comment:
there were tests for it before the "StringView massacre" but I threw the
baby out with the bathwater, added test for it (yes it aims to replace the
`StringToBool`, but they have slightly different semantics for now, and
`StringToBool` is used in many places, so I would retire `StringToBool`
separately)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
