szaszm commented on a change in pull request #937: URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r529764206
########## File path: encrypt-config/ArgParser.cpp ########## @@ -0,0 +1,187 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <string> +#include <set> +#include <iostream> +#include <algorithm> +#include "ArgParser.h" +#include "utils/OptionalUtils.h" +#include "utils/StringUtils.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace encrypt_config { + +const std::vector<Argument> Arguments::simple_arguments_{ + {std::vector<std::string>{"--minifi-home", "-m"}, + true, + "minifi home", + "Specifies the home directory used by the minifi agent"} +}; + +const std::vector<FlagArgument> Arguments::flag_arguments_{ + {std::vector<std::string>{"--help", "-h"}, + "Prints this help message"}, + {std::vector<std::string>{"--encrypt-flow-config"}, + "If set, the flow configuration file (as specified in minifi.properties) is also encrypted."} +}; + +std::string Arguments::getHelp() { + std::stringstream ss; + ss << "Usage: " << "encrypt-config"; + for (const auto& simple_arg : simple_arguments_) { + ss << " "; + if (!simple_arg.required) { + ss << "["; + } + ss << utils::StringUtils::join("|", simple_arg.names) + << " <" << simple_arg.value_name << ">"; + if (!simple_arg.required) { + ss << "]"; + } + } + for (const auto& flag : flag_arguments_) { + ss << " [" << utils::StringUtils::join("|", flag.names) << "]"; + } + ss << std::endl; + for (const auto& simple_arg : simple_arguments_) { + ss << "\t"; + ss << utils::StringUtils::join("|", simple_arg.names) << " : "; + if (simple_arg.required) { + ss << "(required)"; + } else { + ss << "(optional)"; + } + ss << " " << simple_arg.description; + ss << std::endl; + } + for (const auto& flag : flag_arguments_) { + ss << "\t" << utils::StringUtils::join("|", flag.names) << " : " + << flag.description << std::endl; Review comment: It's more about developing habits so that we automatically do the right thing when it actually matters. And also writing "good c++" which is a much smaller subset than "c++" and the guideline excludes `endl` from the "good" subset. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
