lordgamez commented on a change in pull request #939:
URL: https://github.com/apache/nifi-minifi-cpp/pull/939#discussion_r529721982
##########
File path: CONTROLLERS.md
##########
@@ -35,5 +35,7 @@ default values, and whether a property supports the NiFi
Expression Language.
| Name | Default Value | Allowable Values | Expression Language Supported? |
Description |
| - | - | - | - | - |
-| **Access Key** | | | Yes | Specifies the AWS Access Key |
-| **Secret Key** | | | Yes | Specifies the AWS Secret Key |
+|**Use Default Credentials**|false||No|If true, uses the Default Credential
chain, including EC2 instance profiles or roles, environment variables, default
user credentials, etc.|
+|Access Key|||Yes|Specifies the AWS Access Key|
Review comment:
I actually changed it to not be required anymore (removed the * in the
docs). The validation starts with the Use Default Credentials, if it is set it
will go through the AWS chain and try to get the credentials from there. If
it's not found then it checks if the Access Key and Secret Key are set and uses
them as credentials if both are set. If those are not set either it checks if
the Credentials File is set and tries to read the access key and secret key
properties from that file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
