adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r529261449
##########
File path: libminifi/include/c2/C2Payload.h
##########
@@ -164,10 +161,9 @@ class C2Payload : public state::Update {
bool isContainer() const noexcept { return is_container_; }
void setContainer(bool is_container) noexcept { is_container_ =
is_container; }
- /**
- * Get nested payloads.
- */
- const std::vector<C2Payload> &getNestedPayloads() const noexcept { return
payloads_; }
+ const std::vector<C2Payload> &getNestedPayloads() const & noexcept { return
payloads_; }
Review comment:
it is, if you plan to overload it with a `&&`-qualified method (which
was "necessitated" by some `C2Agent` methods taking rvalue ref payloads, but
did not yet untangle them in this PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
