Matt Burgess created NIFI-8016:
----------------------------------

             Summary: Hive connection pool dynamic properties cannot be used
                 Key: NIFI-8016
                 URL: https://issues.apache.org/jira/browse/NIFI-8016
             Project: Apache NiFi
          Issue Type: Bug
          Components: Extensions
            Reporter: Matt Burgess


There is code in all versions of HiveConnectionPool to retrieve all dynamic 
(aka user-defined) properties and set them as key/value pairs on the Hive 
configuration. However there are two issues with this:

1) There is no getSupportedDynamicPropertyDescriptor() method defined, so 
adding a dynamic property to the controller service renders it invalid. There 
should be unit test(s) that exercise this, but there are not.

2) This behavior is inconsistent with DBCPConnectionPool, which uses dynamic 
properties to set properties on the DataSource that aren't available as 
explicit properties on the controller service (see 
https://commons.apache.org/proper/commons-dbcp/configuration.html for the list 
of available properties)

It seems more useful and consistent to have the dynamic properties act the same 
way as they do in DBCPConnectionPool. Adding properties to the Hive config can 
be done in the config file itself, or pointing at an additional configuration 
file containing the desired Hive properties. Since this feature can't currently 
be used anyway, we can change the behavior without user impact.

This should include adding documentation to the controller service explaining 
what the dynamic properties do. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to