adamdebreceni commented on a change in pull request #932:
URL: https://github.com/apache/nifi-minifi-cpp/pull/932#discussion_r513332425
##########
File path: libminifi/src/CronDrivenSchedulingAgent.cpp
##########
@@ -56,8 +56,8 @@ utils::TaskRescheduleInfo
CronDrivenSchedulingAgent::run(const std::shared_ptr<c
} else {
Bosma::Cron schedule(processor->getCronPeriod());
result = schedule.cron_to_next(from);
- last_exec_[uuidStr] = result;
- schedules_.insert(std::make_pair(uuidStr, schedule));
+ last_exec_[uuid] = result;
+ schedules_.insert(std::make_pair(uuid, schedule));
Review comment:
I think they have different semantics, your proposal overwrites if it
already exists, the current version does not change the map if there was a same
key in it, unclear if that was intentional (probably not) but I wanted to
change semantics as little as possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
