pgyori opened a new pull request #4603: URL: https://github.com/apache/nifi/pull/4603
https://issues.apache.org/jira/browse/NIFI-7922 #### Description of PR Adds support for GET in ListenHTTP for health check. GET was not supported in ListenHTTP so when put behind a load balancer, the load balancer could not perform a health check on the HTTP server. This PR fixes that. GET requests sent to <ListenHTTP_service_URI>/healthcheck return "200 OK" with an empty response body. Accessing the health check service can be difficult if the processor is configured to use 2-way SSL, since some load balancers do not support client certificate handling. For this reason, it is also possible to specify a different port, where only the health check service is available. When accessing the health check service via its dedicated port, 1-way SSL is used at most, as follows: - If the processor is set not to use SSL, SSL is not used on the health check port, either. - If the processor is set to use one-way SSL, one-way SSL is used on the health check port. - If the processor is set to use two-way SSL, one-way SSL is used on the health check port. When accessing the server via the dedicated health check port, no other service can accessed and no requests are supported other than GET and HEAD. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on JDK 8? - [ ] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
