fgerlits commented on a change in pull request #921:
URL: https://github.com/apache/nifi-minifi-cpp/pull/921#discussion_r504119213
##########
File path: extensions/civetweb/processors/ListenHTTP.h
##########
@@ -205,13 +193,17 @@ class ListenHTTP : public core::Processor {
void notifyStop() override;
private:
- // Logger
- std::shared_ptr<logging::Logger> logger_;
+ static const std::size_t DEFAULT_BUFFER_SIZE;
+ void processIncomingFlowFile(core::ProcessSession *session);
+ void processRequestBuffer(core::ProcessSession *session);
+
+ std::shared_ptr<logging::Logger> logger_;
CivetCallbacks callbacks_;
std::unique_ptr<CivetServer> server_;
std::unique_ptr<Handler> handler_;
std::string listeningPort;
+ std::size_t batch_size_;
Review comment:
I know it will be set in `onSchedule()`, but I think it would be better
to initialize `batch_size_`, either here or in the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
