Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/33#discussion_r79064157
  
    --- Diff: 
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/ConfigSchema.java
 ---
    @@ -42,10 +44,14 @@
      *
      */
     public class ConfigSchema extends BaseSchema {
    -    public static final String 
FOUND_THE_FOLLOWING_DUPLICATE_PROCESSOR_NAMES = "Found the following duplicate 
processor names: ";
    -    public static final String 
FOUND_THE_FOLLOWING_DUPLICATE_CONNECTION_NAMES = "Found the following duplicate 
connection names: ";
    +    public static final String FOUND_THE_FOLLOWING_DUPLICATE_PROCESSOR_IDS 
= "Found the following duplicate processor ids: ";
    +    public static final String 
FOUND_THE_FOLLOWING_DUPLICATE_CONNECTION_IDS = "Found the following duplicate 
connection ids: ";
         public static final String 
FOUND_THE_FOLLOWING_DUPLICATE_REMOTE_PROCESSING_GROUP_NAMES = "Found the 
following duplicate remote processing group names: ";
    +    public static final String 
FOUND_THE_FOLLOWING_DUPLICATE_REMOTE_INPUT_PORT_IDS = "Found the following 
duplicate remote input port ids: ";
    +    public static final String FOUND_THE_FOLLOWING_DUPLICATE_IDS = "Found 
the following ids that occur both in Processors and Remote Input Ports: ";
    --- End diff --
    
    This brings up a good point that all the ids within a PG (ie. all the ids 
we have) will have to be unique. So will need to add a check including 
connections and RPGs themselves.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to