nickwallen commented on a change in pull request #1523: METRON-2232 Upgrade to
Hadoop 3.1.1
URL: https://github.com/apache/metron/pull/1523#discussion_r338661653
##########
File path: pom.xml
##########
@@ -148,6 +148,7 @@
<global_storm_kafka_version>1.2.3</global_storm_kafka_version>
<global_zeppelin_version>0.8.0</global_zeppelin_version>
<global_solr_version>7.4.0</global_solr_version>
+ <base_hadoop_version>3.1.1</base_hadoop_version>
Review comment:
In this pom, outside of the HDP-3.1 profile, we still have...
```
<base_hadoop_version>2.7.1</base_hadoop_version>
<global_hadoop_version>${base_hadoop_version}</global_hadoop_version>
```
And then inside the HDP-3.1 profiler we redefine...
```
<base_hadoop_version>3.1.1</base_hadoop_version>
```
This all seems confusing to me.
Can we just follow what we did for the other versions like Zookeeper,
Curator, HBase, etc? We could just define a single `global_hadoop_version` in
each profile and then get rid of this `base_hadoop_version` business altogether.
```
<global_hadoop_version>3.1.1</global_hadoop_version>
```
And ultimately before we merge this feature branch into master, we will
remove the HDP-2.5.0.0 profile in the POM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
