[
https://issues.apache.org/jira/browse/METRON-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495838#comment-16495838
]
ASF GitHub Bot commented on METRON-1588:
----------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/metron/pull/1039
METRON-1588 Migrate storm-kafka-client to 1.2.1
## Contributor Comments
Storm community defines storm-kafka-client 1.1.0 to be "unstable" and says
1.2.0 to be stabled one, because Storm community resolved 40 issues including
critical and blocker from 1.2.0.
There're still couple of issues after 1.2.0 so better to sync up the
version to the latest, so I suggest Metron to upgrade the version to the
latest, 1.2.1.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/metron METRON-1588-with-relocation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1039.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1039
----
commit 0382fcc71bdfe29588a2913680f9f9a87e68db16
Author: Jungtaek Lim <kabhwan@...>
Date: 2018-05-29T01:01:54Z
Upgrade storm-kafka-client to 1.2.1
* this incurs additional transitive dependencies
* com.fasterxml.jackson.core:jackson-databind:jar:2.6.3:compile
* com.google.guava:guava:jar:16.0.1:compile
* commons-lang:commons-lang:jar:2.5:compile
commit 056dcabdb634bc6756b52ea4e96fbda1bf0e2e5f
Author: Jungtaek Lim <kabhwan@...>
Date: 2018-05-29T04:14:35Z
Relocate new transitive dependencies from storm-kafka-client
commit a586c47f86a1354bc6d8764e44af8750f7de010d
Author: Jungtaek Lim <kabhwan@...>
Date: 2018-05-29T05:58:09Z
Remove unnecessary version properties / conflicted dependency
commit 4c43cf0ea39e0ebedefb5c2e31f4940bbec7a696
Author: Jungtaek Lim <kabhwan@...>
Date: 2018-05-29T06:45:31Z
Fix dependency to avoid adding unnecessary dependency
commit baf76f3cb5478ee56ddfc3a5cc301743e317044f
Author: Jungtaek Lim <kabhwan@...>
Date: 2018-05-29T07:36:01Z
Update dependencies
----
> Migrate storm-kafka-client to 1.2.1
> -----------------------------------
>
> Key: METRON-1588
> URL: https://issues.apache.org/jira/browse/METRON-1588
> Project: Metron
> Issue Type: Improvement
> Reporter: Jungtaek Lim
> Priority: Critical
>
> Storm community defines storm-kafka-client 1.1.0 to be "unstable" and says
> 1.2.0 to be stabled one, because Storm community resolved 40 issues including
> critical and blocker from 1.2.0.
> There're still couple of issues after 1.2.0 so better to sync up the version
> to the latest, so I suggest Metron to upgrade the version to the latest,
> 1.2.1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
