Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1021#discussion_r189907609
  
    --- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/enrichment/handler/StellarConfig.java
 ---
    @@ -142,8 +143,14 @@ else if(kv.getValue() instanceof List) {
       {
     
    --- End diff --
    
    or - do what you are doing, but just support named maps and use some 
default name for the message itself.
    
    It feels like '_' conflates the 'messaging' with the language.  ( I say 
feels, because obviously I'm just expressing an opinion ). 
    
    This code makes the message the namespace, but then makes you reference the 
namespace with get map instead of just by name... or seems to.
    
    Also, I hope some of these MAAS applications make it into Metron /contrib ;)



---

Reply via email to