[ 
https://issues.apache.org/jira/browse/METRON-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458072#comment-16458072
 ] 

ASF GitHub Bot commented on METRON-1489:
----------------------------------------

Github user anandsubbu commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1004#discussion_r184888777
  
    --- Diff: 
metron-interface/metron-alerts/e2e/utils/clean_metron_update_table.ts ---
    @@ -0,0 +1,52 @@
    +declare var Promise: any;
    +var chalk = require('chalk');
    +var Client = require('ssh2').Client;
    +var errorMsg = '';
    +
    +export function cleanMetronUpdateTable() {
    +  return  new Promise(
    +      function (resolve, reject) {
    +        // resolve();
    +        cleanupTable(resolve, reject);
    --- End diff --
    
    IMHO, it would be better to default to `resolve()` only owing to the issues 
with Vagrant `ssh2` client. 


> Retrofit UI tests to run reliably during nightly QE runs
> --------------------------------------------------------
>
>                 Key: METRON-1489
>                 URL: https://issues.apache.org/jira/browse/METRON-1489
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Daniel Toth
>            Assignee: Daniel Toth
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to