[
https://issues.apache.org/jira/browse/METRON-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350434#comment-16350434
]
ASF GitHub Bot commented on METRON-1438:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/920#discussion_r165663581
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/ShellFunctionsTest.java
---
@@ -40,8 +45,8 @@
);
Context context = new Context.Builder()
- .with(Context.Capabilities.SHELL_VARIABLES , () -> variables)
- .build();
+ .with(Context.Capabilities.SHELL_VARIABLES , () ->
variables).build();
--- End diff --
Right now, I never let my IDE reformat for me. Like you said, if we get
the code base matching check style and I can load that style into my IDE, then
I'd gladly let it do most of the work for me.
Maybe I'll open a discuss thread. I don't know how to handle this kind of
thing and it happens all the time.
But for this specific scenario in your PR, it really doesn't matter either
way. I think you're good to go either way.
> STELLAR: Move shell functions to common from metron-management
> --------------------------------------------------------------
>
> Key: METRON-1438
> URL: https://issues.apache.org/jira/browse/METRON-1438
> Project: Metron
> Issue Type: Sub-task
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
