[ 
https://issues.apache.org/jira/browse/METRON-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268047#comment-16268047
 ] 

ASF GitHub Bot commented on METRON-1329:
----------------------------------------

Github user ottobackwards commented on the issue:

    https://github.com/apache/metron-bro-plugin-kafka/pull/4
  
    +1
    -  review looks good
    - ran through test steps, everything works as described
    
    Great job!


> Simplify metron-bro-plugin-kafka package loading
> ------------------------------------------------
>
>                 Key: METRON-1329
>                 URL: https://issues.apache.org/jira/browse/METRON-1329
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Jon Zeolla
>            Assignee: Jon Zeolla
>            Priority: Trivial
>
> You should be able to load metron-bro-plugin-kafka by adding @load packages 
> to local.bro, and running bro-pkg install apache/metron-bro-plugin-kafka and 
> bro-pkg load apache/metron-bro-plugin-kafka.  Right now, when you do that you 
> will get the following error:
> error in /usr/local/bro/share/bro/site/local.bro, line 106: "redef" used but 
> not previously defined (Kafka::logs_to_send)
> Because loads_to_send is exported in Bro/Kafka/logs-to-kafka.bro.  Instead of 
> forcing manual intervention after bro-pkg install and load, we should make 
> that all work natively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to