jafarre-bi commented on code in PR #11828:
URL: https://github.com/apache/maven/pull/11828#discussion_r2976309754
##########
impl/maven-di/src/main/java/org/apache/maven/di/impl/InjectorImpl.java:
##########
@@ -99,8 +99,9 @@ public Injector discover(@Nonnull ClassLoader classLoader) {
try (InputStream is = url.openStream();
BufferedReader reader =
new BufferedReader(new
InputStreamReader(Objects.requireNonNull(is)))) {
- for (String line :
- reader.lines().filter(l ->
!l.startsWith("#")).toList()) {
+ for (String line : reader.lines()
+ .filter(l -> !l.isBlank() &&
!l.startsWith("#"))
Review Comment:
Well, the trim isn't necessary with isBlank(). As for one or two filters, I
don't mind either way. Should I change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
