elharo commented on PR #1538: URL: https://github.com/apache/maven-mvnd/pull/1538#issuecomment-4055573222
Looks like someone changed a public method signature without bumping the major version: ``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project mvnd-daemon: Compilation failure Error: /Users/runner/work/maven-mvnd/maven-mvnd/daemon/src/main/java/org/mvndaemon/mvnd/syncontext/DaemonNamedLockFactoryAdapterFactoryImpl.java:[48,9] no suitable constructor found for NamedLockFactoryAdapterFactoryImpl(java.util.Map<java.lang.String,org.eclipse.aether.named.NamedLockFactory>,java.lang.String,java.util.Map<java.lang.String,org.eclipse.aether.internal.impl.synccontext.named.NameMapper>,java.lang.String,org.eclipse.aether.impl.RepositorySystemLifecycle) Error: constructor org.eclipse.aether.internal.impl.synccontext.named.NamedLockFactoryAdapterFactoryImpl.NamedLockFactoryAdapterFactoryImpl(java.util.Map<java.lang.String,org.eclipse.aether.named.NamedLockFactory>,java.util.Map<java.lang.String,org.eclipse.aether.internal.impl.synccontext.named.NameMapper>,java.util.Map<java.lang.String,org.eclipse.aether.spi.locking.LockingInhibitorFactory>,org.eclipse.aether.impl.RepositorySystemLifecycle) is not applicable Error: (actual and formal argument lists differ in length) Error: constructor org.eclipse.aether.internal.impl.synccontext.named.NamedLockFactoryAdapterFactoryImpl.NamedLockFactoryAdapterFactoryImpl(java.util.Map<java.lang.String,org.eclipse.aether.named.NamedLockFactory>,java.lang.String,java.util.Map<java.lang.String,org.eclipse.aether.internal.impl.synccontext.named.NameMapper>,java.lang.String,java.util.Map<java.lang.String,org.eclipse.aether.spi.locking.LockingInhibitorFactory>,org.eclipse.aether.impl.RepositorySystemLifecycle) is not applicable Error: (actual and formal argument lists differ in length) Error: -> [Help 1] ``` Your annual reminder that just because something is marked `internal.impl` doesn't mean it isn't depended on. public is public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
