elharo commented on PR #785:
URL: 
https://github.com/apache/maven-shade-plugin/pull/785#issuecomment-3958913195

   Standard best practice. PRs should be small and focused on one thing. 
   
   https://google.github.io/eng-practices/review/developer/small-cls.html
   https://testing.googleblog.com/2024/07/in-praise-of-small-pull-requests.html
   
   In the specific case of Maven, it helps a lot with code archaeology in the 
future. It has not escaped my notice that on another PR in surefire right now 
we are unable to understand why changes were made in a PR that did several 
things and only documented one of them, and consequently progress is blocked.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to