desruisseaux commented on code in PR #11700:
URL: https://github.com/apache/maven/pull/11700#discussion_r2833451455
##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -520,7 +520,7 @@ List<ProjectBuildingResult> doBuild(List<File> pomFiles,
boolean recursive) {
return pomFiles.stream()
.map(pomFile -> build(pomFile, recursive))
.flatMap(List::stream)
- .collect(Collectors.toList());
+ .toList();
Review Comment:
3 separated pull requests would be clearer if they were 3 independent tasks.
But in this case, each new pull request is amending the previous one, for
example adding warnings, then changing warnings into build failures. In this
case, I think that squashing the 3 pull requests make them easier to analyse,
because reviewers can analyse directly the final result instead of spending
times on changes that are made obsolete in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
