Copilot commented on code in PR #1352:
URL: https://github.com/apache/maven-scm/pull/1352#discussion_r2649094787
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java:
##########
@@ -226,10 +229,16 @@ private RepositoryUrl parseUrl(String url) throws
ScmException {
}
/**
- * @param repoUrl
- * @return TODO
+ * Builds the effective Git repository URL from the parsed SCM URL
+ * definition.
+ *
+ * @param repoUrl parsed repository descriptor containing host,
+ * protocol, and path information
+ * @return the normalized remote repository URL that Maven SCM will
+ * use for Git operations
*/
private String getUrl(RepositoryUrl repoUrl) {
+
Review Comment:
An unnecessary blank line has been added within the method body. This
deviates from the surrounding code style where the method body starts
immediately after the opening brace. The blank line should be removed to
maintain consistency.
```suggestion
```
##########
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-git-commons/src/main/java/org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java:
##########
@@ -75,8 +75,11 @@ public class GitScmProviderRepository extends
ScmProviderRepositoryWithHost {
public static final String PROTOCOL_HTTPS = "https";
/**
- * Use rsync for retrieving the data
- * TODO implement!
+ * Protocol identifier for repositories accessed via <code>rsync</code>.
+ *
+ * This value is used when parsing SCM URLs and represents a repository
+ * that is retrieved using the rsync protocol. Currently, rsync is
+ * recognized but not actively implemented by the Git SCM provider.
Review Comment:
The documentation states "Currently, rsync is recognized but not actively
implemented by the Git SCM provider," which is misleading. Looking at the code,
PROTOCOL_RSYNC is actually parsed from URLs (line 321-322), included in
urlSupportsUserInformation (line 246), and used to construct repository URLs.
While there may not be special rsync-specific handling, the protocol is
functionally supported like other protocols. The documentation should clarify
what "not actively implemented" means, or if rsync is actually fully supported,
the documentation should reflect that accurately.
```suggestion
* This value is used when parsing SCM URLs and constructing repository
* URLs that use the rsync protocol. The Git SCM provider does not apply
* any rsync-specific behavior; rsync-based URLs are handled in the same
* generic way as other supported protocols.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
