Bukama commented on issue #84:
URL: 
https://github.com/apache/maven-jmod-plugin/issues/84#issuecomment-3693044146

   > If you look at a trivial PR like 
[#89](https://github.com/apache/maven-jmod-plugin/pull/89) we see that all ITs 
are passing, including on Windows including [windows-latest jdk-25-zulu 3.9.12 
(push)](https://github.com/apache/maven-jmod-plugin/actions/runs/20430517070/job/58700144437?pr=89).
 Is there a particular config we're missing where they are failing?
   
   Didn't see any set in the maven-verify shared actions, so not sure.
   
   When I look at the generated command that gets executed
   
   > Exit code: 2
   Command line was: cmd.exe /X /C "C:\JDK\Java25\bin\jmod.exe create 
--module-version=99.0 
--class-path=D:\\Github\\Maven\\maven-jmod-plugin\\target\\it\\base-config\\target\\classes
 
--config=D:\Github\Maven\maven-jmod-plugin\target\it\base-config\src\main\configs
 
--module-path=D:\\Github\\Maven\\maven-jmod-plugin\\target\\it\\base-config\\target\\classes;C:\\JDK\\Java25\\jmods
 
D:\Github\Maven\maven-jmod-plugin\target\it\base-config\target\jmods\maven-jmod-plugin-base-config.jmod"
   
   and try to run it, it fails as there is a directory mentioned, which does 
not exists `C:\\JDK\\Java25\\jmods`
   
   > Fehler: Pfad nicht gefunden: C:\JDK\Java25\jmods
   
   
   This directory does not exists in any of my installed JDK. Aside from the 
test test step failing is checking a `.jmod` file in the `jmods` folder of the 
ITs target folder.
   
   > def artifact = new File( target, 
'jmods/maven-jmod-plugin-base-config.jmod' )
   
   resulting in the absolute path of the tests: 
`D:\Github\Maven\maven-jmod-plugin\target\it\base-config\target/jmods/maven-jmod-plugin-base-config.jmod`.
 The "jmods" folder gets created, but no file in there (obvious - otherwise the 
test would succeeded).
   
   
   In the create JmodMojo there is
   
   ```
               File jmodsFolderJDK = new File(javaHome, JMODS);
               getLog().debug("Parent: " + javaHome.getAbsolutePath());
               getLog().debug("jmodsFolder: " + 
jmodsFolderJDK.getAbsolutePath());
   ```
   
   This path is not checked. If I add
   
   ```
               if(!jmodsFolderJDK.exists()) {
                   throw new IOException("Jmods folder does not exists");
               }
   ```
   
   it fails with exact that message
   
   > Caused by: java.io.IOException: Jmods folder does not exists


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to