jira-importer commented on issue #221:
URL: 
https://github.com/apache/maven-war-plugin/issues/221#issuecomment-2967853770

   **[David 
Jencks](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=djencks)** 
commented
   
   I think adding this capability is a very good idea.  IIUC the only argument 
against it is that it is possible to get the same effect by putting the classes 
into a separate project.  I think this ignores the different effects and affect 
of having 2 projects:
   
   1. Having 2 projects forces you to maintain what you are likely to be 
thinking of as one project in two places: e.g. even without jsps, the web.xml 
is going to be far away in the file system and IDE from the classes it is the 
descriptor for.  I think breaking the way people think about their project in 
this way is inadvisable.
   
   2. If you have jsps, you cannot precompile them and include them in the 
project classes jar without moving them into the classes project.  What should 
be a packaging option requires major svn changes to your project.
   
   3. With 2 projects you are forced to publish the classes jar.  You may not 
want to pollute your repo with this artifact that you may regard as 
unnecessary.  Also, you are apt to want to name both projects with the same 
name.
   
   4. If you want 2 profiles, one to pack classes into a jar and the other to 
leave them in WEB-INF/classes, you are forced to unpack the jar if the jar is 
from a separate project.  This is going to be a bit slower than not creating 
the jar  in the first place.
   
   I'm sure there are more, this is just what came to mind during a moments 
consideration.  war files are a pretty strange and perhaps inadvisable 
construction, but I think it is better for maven to try to adapt to what they 
are and how they are used rather than trying to force everyone to essentially 
use something else.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to