[
https://issues.apache.org/jira/browse/SCM-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17961250#comment-17961250
]
ASF GitHub Bot commented on SCM-379:
------------------------------------
jira-importer commented on issue #598:
URL: https://github.com/apache/maven-scm/issues/598#issuecomment-2964606078
**[Siveton
Vincent](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=siveton)**
commented
Fixed in [r687028](http://svn.apache.org/viewvc?rev=687028&view=rev) without
your patch.
> SCM URL with query transformed incorrectly on release:prepare
> -------------------------------------------------------------
>
> Key: SCM-379
> URL: https://issues.apache.org/jira/browse/SCM-379
> Project: Maven SCM (Moved to GitHub Issues)
> Issue Type: Bug
> Components: maven-scm-provider-svn
> Affects Versions: 1.0
> Reporter: Doron Solomon
> Assignee: Siveton Vincent
> Priority: Major
> Fix For: 1.1
>
> Attachments: SvnTagBranchUtils.java
>
>
> Given the following scm definition:
> <scm>
> <connection>scm:svn:https://myserver/svn/myproj/pom/trunk</connection>
>
> <developerConnection>scm:svn:https://myserver/svn/myproj/pom/trunk</developerConnection>
> <url>https://myserver/plugins/scmsvn/viewcvs.php/pom/trunk?root=myproj</url>
> </scm>
> Running the release:prepare goal transforms this to the following (in the POM
> associated to the tag):
> <scm>
>
> <connection>scm:svn:https://myserver/svn/myproj/pom/tags/mytag-1</connection>
>
> <developerConnection>scm:svn:https://myserver/svn/myproj/pom/tags/mytag-1</developerConnection>
>
> <url>https://myserver/plugins/scmsvn/viewcvs.php/pom/trunk?root=myproj/tags/mytag-1?root=myproj</url>
> </scm>
> The <url> element is incorrect, as it is adding the query "?root=myproj"
> twice. The desired url tag is:
>
> <url>https://myserver/plugins/scmsvn/viewcvs.php/pom/tags/mytag-1?root=myproj</url>
> The problem is in the class
> org.apache.maven.scm.provider.svn.SvnTagBranchUtils (in artifact
> org.apache.maven.scm:maven-scm-providers-svn). The method resolveUrl is
> considering the case where the URL contains a query string, but is not
> removing the query part of the URL before transforming it. The attached java
> file contains the patched version of this class that I have tested.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
