[ 
https://issues.apache.org/jira/browse/SCM-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963669#comment-17963669
 ] 

ASF GitHub Bot commented on SCM-921:
------------------------------------

jira-importer commented on issue #1149:
URL: https://github.com/apache/maven-scm/issues/1149#issuecomment-2964648718

   **[Alex 
Harui](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aharui)** 
commented
   
   Actually, I am still having this problem, there was just more to it than I 
thought.
   
   The root cause, IMO, is that the fileset passed into JGitUtils.java's 
addAllFiles by the Maven Release Plugin when updating pom versions (on Windows 
Server) seems to contain "c:\path\to\repo\pom.xml" for the root pom, but 
"C:\path\to\repo\submodule\pom.xml" for the submodules.  Note the lowercase 'c' 
for the root pom.xml and uppercase 'C' for the submodules.
   
   Then in JGitUtils.relativize, the call to java.net.URI's relativize works 
for uppercase 'C' but not lowercase 'c'.  
   
   I was wrong when I said I was no longer having this problem as the fileset I 
was working with recently did not have any files from the repo root because I 
was working on the scenario in SCM-932.
   
   I am going to try to find out why a lowercase 'c' is being passed in in the 
first place.
   




> maven-scm-provider-jgit not handling relative paths on Windows Server
> ---------------------------------------------------------------------
>
>                 Key: SCM-921
>                 URL: https://issues.apache.org/jira/browse/SCM-921
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-jgit
>    Affects Versions: 1.11.1
>            Reporter: Alex Harui
>            Priority: Major
>         Attachments: SCM-921.patch
>
>
> Running Maven release plugin with jgit on Windows Server, the pom.xml files 
> in subfolders would not get committed.  The main pom.xml file would.  Upon 
> investigation it appears that Maven passed in absolute paths to the 
> subfolders starting with C:\ and JGIT's relativize only works correctly for 
> c:\ (note capitalization difference).  So I patched maven-scm-provider-jgit 
> to lowercase the first letter of an absolute path if it detects the path has 
> ":\" at index 1 and it appears to be working now.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to