[ 
https://issues.apache.org/jira/browse/MINDEXER-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17965254#comment-17965254
 ] 

Olivier Lamy commented on MINDEXER-42:
--------------------------------------

This project has moved from Jira to GitHub Issues. This issue was migrated to 
[apache/maven-indexer#449|https://github.com/apache/maven-indexer/issues/449]. 

> WagonHelper.getWagonResourceFetcher does not support HTTPS
> ----------------------------------------------------------
>
>                 Key: MINDEXER-42
>                 URL: https://issues.apache.org/jira/browse/MINDEXER-42
>             Project: Maven Indexer (Moved to GitHub Issues)
>          Issue Type: Bug
>    Affects Versions: 4.1.2
>            Reporter: Jesse N. Glick
>            Assignee: Olivier Lamy
>            Priority: Minor
>             Fix For: 4.1.3
>
>
> The intent of {{WagonHelper.getWagonResourceFetcher}} is to make it easy to 
> use Wagon as a transport when available. In practice, it is useless since it 
> cannot handle HTTPS connections.
> The workaround is simple - construct a {{WagonFetcher}} directly with the 
> desired scheme - but then the existing convenience methods should not be 
> used. Recommend deprecating them, and optionally introducing a replacement
> {code:java}
>     public WagonFetcher getWagonResourceFetcher( final TransferListener 
> listener, final String protocol,
>                                                  final AuthenticationInfo 
> authenticationInfo, final ProxyInfo proxyInfo )
>         throws ComponentLookupException
>     {
>         return new WagonFetcher( plexusContainer.lookup( Wagon.class, 
> protocol ), listener, authenticationInfo, proxyInfo );
>     }
> {code}
> or
> {code:java}
>     public WagonFetcher getWagonResourceFetcher( final TransferListener 
> listener, final String indexUpdateUrl,
>                                                  final AuthenticationInfo 
> authenticationInfo, final ProxyInfo proxyInfo )
>         throws ComponentLookupException
>     {
>         return new WagonFetcher( plexusContainer.lookup( Wagon.class, 
> URI.create( indexUpdateUrl ).getScheme() ), listener, authenticationInfo, 
> proxyInfo );
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to