[ 
https://issues.apache.org/jira/browse/SCM-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17962339#comment-17962339
 ] 

ASF GitHub Bot commented on SCM-647:
------------------------------------

jira-importer opened a new issue, #846:
URL: https://github.com/apache/maven-scm/issues/846

   **[Petr 
Kozelka](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pkozelka)**
 opened 
**[SCM-647](https://issues.apache.org/jira/browse/SCM-647?redirect=false)** and 
commented
   
   Current implementations uses non-xml svn log for gathering information. It 
always returns everything after 5th char as the filename, which is a bug in 
cases like this:
   
   > A 
/maven/scm/trunk/maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java
 (from 
/maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/ScmTestCase.java:191665)
   > which indicate copying a path from existing revision.
   
   Note that this example was taken from the [svnlog2.txt line 
510](https://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/resources/svn/changelog/svnlog2.txt?view=markup#l510)
 file in test resources.
   
   I suggest to fix it with the attached patch. It also enhances tests to 
assert that the parsed filenames are correct - not containing spaces and 
beginning with common path.
   
   
   ---
   
   **Affects:** 1.5, 1.6
   
   **Attachments:**
   - 
[scm-svn-origfile.patch](https://issues.apache.org/jira/secure/attachment/12718904/scm-svn-origfile.patch)
 (_3.79 kB_)
   




> SvnChangeLogConsumer parses filename incorrectly when file is copied from 
> existing one
> --------------------------------------------------------------------------------------
>
>                 Key: SCM-647
>                 URL: https://issues.apache.org/jira/browse/SCM-647
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Bug
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.5, 1.6
>            Reporter: Petr Kozelka
>            Assignee: Olivier Lamy
>            Priority: Major
>             Fix For: 1.6
>
>         Attachments: scm-svn-origfile.patch
>
>
> Current implementations uses non-xml svn log for gathering information. It 
> always returns everything after 5th char as the filename, which is a bug in 
> cases like this:
> {quote}   A 
> /maven/scm/trunk/maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java
>  (from 
> /maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/ScmTestCase.java:191665){quote}
> which indicate copying a path from existing revision.
> Note that this example was taken from the [svnlog2.txt line 
> 510|https://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/resources/svn/changelog/svnlog2.txt?view=markup#l510]
>  file in test resources.
> I suggest to fix it with the attached patch. It also enhances tests to assert 
> that the parsed filenames are correct - not containing spaces and beginning 
> with common path.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to