Pankraz76 commented on code in PR #2375:
URL: https://github.com/apache/maven/pull/2375#discussion_r2133700626
##########
impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java:
##########
@@ -77,8 +107,16 @@ void testAptConsistency() throws Exception {
ArtifactHandler handler =
container.lookup(ArtifactHandlerManager.class).getArtifactHandler(type);
assertEquals(handler.getExtension(), extension, type + "
extension");
- // Packaging/Directory is Maven1 remnant!!!
- // assertEquals(handler.getPackaging(), packaging, type + "
packaging");
Review Comment:
better some special workaround assert than no at all!
Agree upon test code allowed some flexibility like having **commented out
code**. So lets use this liberty to improve the test by testing the production
code.
This topic remains, but we have cleared up the doing and increased coverage.
If/as no ability to fix it yet, might consider take the increment and go for
next increment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
