gnodet commented on PR #2406: URL: https://github.com/apache/maven/pull/2406#issuecomment-2949521120
> yes, the now explicitly methods are kind of overhead, as empty like before, would be nice to have them in some kind of default impl. > > Whats the matter? Its just the same method and signature, right? Empty methods will behave the same, assuming your concern is about architectural design? > > To me this change only shows the real intent of this method. > > Before it was a secret to override this methods, even tho its actually part of API, now as they are `abstract`, what they seem to be in real world, its clear and part of the contract. All _protected_ methods can be overridden, that's no secret. It's a way to customize the request/result. As we see, it's usually not needed, so not sure why we'd have to force derived classes to provide two empty methods. I don't think the burden outweighs the benefits here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
