Pankraz76 commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2131941718
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##########
@@ -101,21 +104,14 @@ interface InnerInterpolator {
@Override
public Model interpolateModel(
Model model, Path projectDir, ModelBuilderRequest request,
ModelProblemCollector problems) {
- InnerInterpolator innerInterpolator = createInterpolator(model,
projectDir, request, problems);
- return new
MavenTransformer(innerInterpolator::interpolate).visit(model);
+ return new MavenTransformer(createInterpolator(model, projectDir,
request, problems)::interpolate).visit(model);
}
private InnerInterpolator createInterpolator(
Model model, Path projectDir, ModelBuilderRequest request,
ModelProblemCollector problems) {
-
- Map<String, Optional<String>> cache = new HashMap<>();
Review Comment:
what cache, its only `used one time`? meaning no reference = no cache,
every uses its own.
- https://github.com/pmd/pmd/issues/5770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
