elharo commented on code in PR #2396:
URL: https://github.com/apache/maven/pull/2396#discussion_r2111553285
##########
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java:
##########
@@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo {
private File outputFile;
public void execute() throws MojoExecutionException {
Review Comment:
Not sure how old this code is, perhaps pre-Java 5. This and a lot of other
methods are missing @Override annotations. I also see a lot fo old javadoc
style annotations in these classes.
##########
its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java:
##########
@@ -93,8 +93,8 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " +
outputFile);
OutputStream out = null;
+ outputFile.getParentFile().mkdirs();
Review Comment:
This code is pretty old and not up to 2025 standards. I think we should
merge the try with resources before making this change. Otherwise, line
splitting is making it even less clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
