elharo commented on code in PR #2396:
URL: https://github.com/apache/maven/pull/2396#discussion_r2109264385
##########
its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java:
##########
@@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " +
outputFile);
Review Comment:
delete
##########
its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java:
##########
@@ -70,8 +70,8 @@ public static Properties read(File inputFile) throws
MojoExecutionException {
public static void write(File outputFile, Properties props) throws
MojoExecutionException {
OutputStream os = null;
Review Comment:
This could use try with resources
##########
its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java:
##########
@@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " +
outputFile);
Review Comment:
we should delete this line
##########
its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java:
##########
@@ -36,8 +36,8 @@ class PropertiesUtil {
public static void write(File outputFile, Properties props) throws
MojoExecutionException {
OutputStream out = null;
Review Comment:
This could use try with resources
##########
its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java:
##########
@@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " +
outputFile);
Review Comment:
delete
##########
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java:
##########
@@ -118,8 +118,8 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " +
outputFile);
OutputStream out = null;
Review Comment:
This could use try with resources
##########
its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java:
##########
@@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " +
outputFile);
Review Comment:
This could use try with resources
##########
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java:
##########
@@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo {
private File outputFile;
public void execute() throws MojoExecutionException {
+ outputFile.getParentFile().mkdirs();
Review Comment:
check return value?
##########
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##########
@@ -134,8 +134,8 @@ public void run() {
getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " +
outputFile);
OutputStream out = null;
Review Comment:
This could use try with resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
