Pankraz76 commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2101042778


##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##########
@@ -137,7 +137,7 @@ String callback(
             String expression) {
         String value = doCallback(model, projectDir, request, problems, 
expression);
         if (value != null) {
-            // value = postProcess(projectDir, request, expression, value);

Review Comment:
   - this looks like a real bug.
   - test is green meaning blindspot, might use or loose.
   
   having now good test coverage this seems obsolete. Having the line in place 
seems not to change the 
   behaviour so its outdated as comment tells.
   
   
   <html>
   <body>
   
   100% (1/1) | 100% (11/11) | 98% (78/79) | 91% (55/60)
   -- | -- | -- | --
   
   
   </body>
   </html>�
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to