Pankraz76 commented on code in PR #2326:
URL: https://github.com/apache/maven/pull/2326#discussion_r2086820174
##########
api/maven-api-core/src/main/java/org/apache/maven/api/services/xml/XmlWriterRequest.java:
##########
@@ -55,6 +55,13 @@ static <T> XmlWriterRequestBuilder<T> builder() {
return new XmlWriterRequestBuilder<>();
}
+ default XmlWriterRequest<T> assertWritable() {
+ if (getWriter() == null && getOutputStream() == null && getPath() ==
null) {
+ throw new IllegalArgumentException("writer, outputStream or path
must be non null");
+ }
+ return this;
+ }
Review Comment:
could live somewhere else. Companion or Util.
It belongs here obviously, as everything else require more code, but we can
take it away.
Matter of arch-design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
