Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084111582
##########
pom.xml:
##########
@@ -796,9 +796,68 @@ under the License.</licenseText>
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.openrewrite.maven</groupId>
+ <artifactId>rewrite-maven-plugin</artifactId>
+ <version>6.8.0</version>
+ <configuration>
+ <activeRecipes>
+ <!-- BestPractices -->
+ <!--
<recipe>org.openrewrite.java.recipes.JavaRecipeBestPractices</recipe> -->
+ <!--
<recipe>org.openrewrite.java.recipes.RecipeNullabilityBestPractices</recipe> -->
+ <!--
<recipe>org.openrewrite.java.recipes.RecipeTestingBestPractices</recipe> -->
+ <!-- testing -->
+ <!--
<recipe>org.openrewrite.java.testing.assertj.JUnitToAssertj</recipe> -->
+ <!--
<recipe>org.openrewrite.java.testing.assertj.SimplifyAssertJAssertion</recipe>
-->
+ <!--
<recipe>org.openrewrite.java.testing.junit5.JUnit5BestPractices</recipe> -->
+ <!-- staticanalysis -->
+ <!-- <recipe>org.openrewrite.staticanalysis.CodeCleanup</recipe>
-->
+ <!--
<recipe>org.openrewrite.staticanalysis.CommonStaticAnalysis</recipe> -->
+ <!--
<recipe>org.openrewrite.staticanalysis.FinalizeMethodArguments</recipe> -->
Review Comment:
https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#avoidreassigningparameters
rewrite would make the boilerplate way cluttering `final`; better prefer
silent `PMD`.
https://adabeat.com/fp/immutability-in-functional-programming/
We make everywhere boilerplate to throw NPE ourselfs. This would really help
to make thinks more robust. immutability is/should be the default case. Kotlin
is all about being final and avoiding silly NPE. Thats why we want to live in
final existence. Trying to reach invinity.
https://github.com/apache/maven/pull/2236/files#r2083631201
`smell` never reassign params as we live in final land.
give dedication method and apply functional programming.
<img width="1205" alt="image"
src="https://github.com/user-attachments/assets/190ce68b-f6bc-4c18-85e3-f40d4a5afb7b";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
