Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083620544
##########
pom.xml:
##########
@@ -1159,5 +1159,53 @@ under the License.</licenseText>
</plugins>
</build>
</profile>
+ <profile>
+ <id>rewrite</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.openrewrite.maven</groupId>
+ <artifactId>rewrite-maven-plugin</artifactId>
+ <version>6.8.0</version>
+ <configuration>
+ <exportDatatables>true</exportDatatables>
+ <activeRecipes>
+ <!-- https://github.com/apache/maven/pull/2307 -->
+ <!--
<recipe>org.openrewrite.java.testing.assertj.JUnitToAssertj</recipe> -->
+ <!--
<recipe>org.openrewrite.java.testing.assertj.SimplifyAssertJAssertion</recipe>
-->
+ <!-- https://github.com/apache/maven/pull/2320 -->
+ <!--
<recipe>org.openrewrite.java.testing.junit5.JUnit5BestPractices</recipe> -->
+ <!--
<recipe>org.openrewrite.staticanalysis.CodeCleanup</recipe> -->
+ <!--
<recipe>org.openrewrite.staticanalysis.CommonStaticAnalysis</recipe> -->
+ <!--
<recipe>org.openrewrite.staticanalysis.RemoveUnusedLocalVariables</recipe> -->
+ <!-- https://github.com/apache/maven/pull/2317 -->
+ <!--
<recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateFields</recipe> -->
+ <!-- https://github.com/apache/maven/pull/2310 -->
+
<recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods</recipe>
+ </activeRecipes>
+ </configuration>
+ <dependencies>
+ <dependency>
+ <groupId>org.openrewrite.recipe</groupId>
+ <artifactId>rewrite-static-analysis</artifactId>
+ <version>2.9.0</version>
+ </dependency>
+ </dependencies>
+ <executions>
+ <execution>
+ <id>rewrite-maven-plugin</id>
+ <goals>
+ <goal>run</goal>
Review Comment:
here we need new goal @timtebeek
[`failOnDryRunDetection`](https://github.com/openrewrite/rewrite-maven-plugin/pull/984)
- then we complete request @gnodet.
> which fails the build if a rule cannot be validated
- https://github.com/apache/maven/pull/2300
- https://github.com/apache/maven/pull/2300#issuecomment-2870041976
- https://github.com/openrewrite/rewrite-maven-plugin/pull/984
```suggestion
<goal>ailOnDryRunDetection</goal>
```
##########
pom.xml:
##########
@@ -1159,5 +1159,53 @@ under the License.</licenseText>
</plugins>
</build>
</profile>
+ <profile>
+ <id>rewrite</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.openrewrite.maven</groupId>
+ <artifactId>rewrite-maven-plugin</artifactId>
+ <version>6.8.0</version>
+ <configuration>
+ <exportDatatables>true</exportDatatables>
+ <activeRecipes>
+ <!-- https://github.com/apache/maven/pull/2307 -->
+ <!--
<recipe>org.openrewrite.java.testing.assertj.JUnitToAssertj</recipe> -->
+ <!--
<recipe>org.openrewrite.java.testing.assertj.SimplifyAssertJAssertion</recipe>
-->
+ <!-- https://github.com/apache/maven/pull/2320 -->
+ <!--
<recipe>org.openrewrite.java.testing.junit5.JUnit5BestPractices</recipe> -->
+ <!--
<recipe>org.openrewrite.staticanalysis.CodeCleanup</recipe> -->
+ <!--
<recipe>org.openrewrite.staticanalysis.CommonStaticAnalysis</recipe> -->
+ <!--
<recipe>org.openrewrite.staticanalysis.RemoveUnusedLocalVariables</recipe> -->
+ <!-- https://github.com/apache/maven/pull/2317 -->
+ <!--
<recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateFields</recipe> -->
+ <!-- https://github.com/apache/maven/pull/2310 -->
+
<recipe>org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods</recipe>
+ </activeRecipes>
+ </configuration>
+ <dependencies>
+ <dependency>
+ <groupId>org.openrewrite.recipe</groupId>
+ <artifactId>rewrite-static-analysis</artifactId>
+ <version>2.9.0</version>
+ </dependency>
+ </dependencies>
+ <executions>
+ <execution>
+ <id>rewrite-maven-plugin</id>
+ <goals>
+ <goal>run</goal>
Review Comment:
here we need new goal @timtebeek
[`failOnDryRunDetection`](https://github.com/openrewrite/rewrite-maven-plugin/pull/984)
- then we complete request @gnodet.
> which fails the build if a rule cannot be validated
- https://github.com/apache/maven/pull/2300
- https://github.com/apache/maven/pull/2300#issuecomment-2870041976
- https://github.com/openrewrite/rewrite-maven-plugin/pull/984
```suggestion
<goal>failOnDryRunDetection</goal>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
