Pankraz76 commented on code in PR #2287: URL: https://github.com/apache/maven/pull/2287#discussion_r2083541703
########## impl/maven-core/src/main/java/org/apache/maven/execution/MavenSession.java: ########## @@ -423,13 +422,13 @@ private static Settings adaptSettings(MavenExecutionRequest request) { .localRepository(localRepo != null ? localRepo.getAbsolutePath() : null) .interactiveMode(request.isInteractiveMode()) .offline(request.isOffline()) - .proxies(request.getProxies().stream().map(Proxy::getDelegate).collect(Collectors.toList())) - .servers(request.getServers().stream().map(Server::getDelegate).collect(Collectors.toList())) - .mirrors(request.getMirrors().stream().map(Mirror::getDelegate).collect(Collectors.toList())) Review Comment: can have side effect too when being used outside. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org