Pankraz76 commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2083456022
########## impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.impl; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class PathSelectorTest { + /** + * Creates a temporary directory and checks its list of content based on patterns. + * + * @param directory temporary directory where to create a tree + * @throws IOException if an error occurred while creating a temporary file or directory + */ + @Test + public void testTree(final @TempDir Path directory) throws IOException { + Path foo = Files.createDirectory(directory.resolve("foo")); + Path bar = Files.createDirectory(foo.resolve("bar")); + Path baz = Files.createDirectory(directory.resolve("baz")); + Files.createFile(directory.resolve("root.txt")); + Files.createFile(bar.resolve("leaf.txt")); + Files.createFile(baz.resolve("excluded.txt")); + assertFilteredFilesContains(directory, "", "root.txt", "foo/bar/leaf.txt"); + assertFilteredFilesContains(directory, "glob:", "foo/bar/leaf.txt"); + } + + /** + * Asserts that the filtered set of paths contains the given items and nothing more. + * + * @param directory the temporary directory containing the files to test + * @param syntax syntax to test, either an empty string of {@code "glob:"} + * @param expected the expected paths + * @throws IOException if an error occurred while listing the files + */ + private static void assertFilteredFilesContains(final Path directory, final String syntax, final String... expected) + throws IOException { + var includes = List.of(syntax + "**/*.txt"); + var excludes = List.of(syntax + "baz/**"); + var matcher = new PathSelector(directory, includes, excludes, false); + Set<Path> filtered = + new HashSet<>(Files.walk(directory).filter(matcher::matches).toList()); + for (String path : expected) { + assertTrue(filtered.remove(directory.resolve(path)), path); + } + assertTrue(filtered.isEmpty(), filtered.toString()); + } + + /** + * Tests the omission of unnecessary excludes. + * + * Note: at the time of writing this test (April 2025), the list of excludes goes down from 40 to 17 elements. + * This is not bad, but we could do better with, for example, a special treatment of the excludes that are + * for excluding an entire directory. + */ + @Test + public void testExcludeOmission() { + Path directory = Path.of("dummy"); + var includes = List.of("**/*.java"); + var excludes = List.of("baz/**"); + var matcher = new PathSelector(directory, includes, excludes, true); + String s = matcher.toString(); + assertTrue(s.contains("glob:**/*.java")); + assertFalse(s.contains("project.pj")); // Unnecessary exclusion should have been omitted. + assertFalse(s.contains(".DS_Store")); Review Comment: ```suggestion assertThat(s).contains(".DS_Store"); ``` new code, already, considered, outdated - therefore increasing technical dept. to reach next lvl, we need leadership and team up to standardize `DOD`. <img width="989" alt="image" src="https://github.com/user-attachments/assets/ee0bf423-29b4-44e0-8d0b-36f9cbef9fcd"; /> consider migration to avoid boilerplate API usage. - https://github.com/apache/maven/pull/2307 - https://docs.openrewrite.org/recipes/java/testing/assertj/junittoassertj Still new manual interaction due to bug: - https://github.com/openrewrite/rewrite-testing-frameworks/issues/726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
