elharo commented on code in PR #2278:
URL: https://github.com/apache/maven/pull/2278#discussion_r2082254538
##########
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##########
@@ -37,11 +37,23 @@ public interface SourceRoot {
* The path is relative to the <abbr>POM</abbr> file.
*
* <h4>Default implementation</h4>
- * The default value is <code>src/{@linkplain #scope() scope}/{@linkplain
#language() language}</code>
- * as a relative path. Implementation classes may override this default
with an absolute path instead.
+ * The default value depends on whether a {@linkplain #module() module
name} is specified in this source root:
+ * <ul>
+ * <li>
+ * If no module name, then the default directory is
Review Comment:
I am not convinced. That feels very wrong to me, and I expect users will be
unnecessarily confused. What we've had in the past is
src/main/java/package-structure and the natural extension of that is
src/main/java/module/package-structure
If other languages come into play (which I really don't think will happen or
is something we need to worry about) then src/main/python/module or whatever
Changing anything to src/java/main introduces inconsistency we don't have
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
