telemenar commented on issue #710:
URL: https://github.com/apache/maven-mvnd/issues/710#issuecomment-2852216677

   Last update for a while. (Hopefully) Based on some reading I was doing as I 
posted the ticket to Graal, I learned that the change I referenced above in 
OpenJDK landed in OpenJDK-23. 
   
   So I tried again with OpenJDK-23 and without `~/.mavenrc` and I got what I'd 
hoped for I don't need `-XX:-MaxFDLimit` if I'm using JDK 23:
   ```
   $ rm ~/.mavenrc
   
   $ mvn -version
   Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
   Maven home: /opt/homebrew/Cellar/maven/3.9.9/libexec
   Java version: 23.0.1, vendor: Eclipse Adoptium, runtime: 
/Library/Java/JavaVirtualMachines/temurin-aarch64-23.jdk/Contents/Home
   Default locale: en_US, platform encoding: UTF-8
   OS name: "mac os x", version: "15.1.1", arch: "aarch64", family: "mac"
   
   $ mvn verify
   [INFO] Scanning for projects...
   [INFO]
   [INFO] --------------------< org.example.test:test-ulimit 
>--------------------
   [INFO] Building Ulimit Check 0.1
   [INFO]   from pom.xml
   [INFO] --------------------------------[ pom 
]---------------------------------
   [INFO]
   [INFO] --- exec:3.4.1:exec (set_ulimits) @ test-ulimit ---
   Soft Files Limit
   245760
   Hard Files Limit
   245760
   [INFO] 
------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] 
------------------------------------------------------------------------
   [INFO] Total time:  0.198 s
   [INFO] Finished at: 2025-05-05T13:05:28-07:00
   [INFO] 
------------------------------------------------------------------------
   ```
   
   For more fun if I limit the soft limit down we can see that it correctly 
raises it to the hard limit:
   ```
   $ ulimit -Sn 1000
   
   $ mvn verify
   [INFO] Scanning for projects...
   [INFO]
   [INFO] --------------------< org.example.test:test-ulimit 
>--------------------
   [INFO] Building Ulimit Check 0.1
   [INFO]   from pom.xml
   [INFO] --------------------------------[ pom 
]---------------------------------
   [INFO]
   [INFO] --- exec:3.4.1:exec (set_ulimits) @ test-ulimit ---
   Soft Files Limit
   245760
   Hard Files Limit
   245760
   [INFO] 
------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] 
------------------------------------------------------------------------
   [INFO] Total time:  0.256 s
   [INFO] Finished at: 2025-05-05T13:09:03-07:00
   [INFO] 
------------------------------------------------------------------------
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to