[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947204#comment-17947204
]
ASF GitHub Bot commented on MBUILDCACHE-123:
--------------------------------------------
zrlw opened a new pull request, #209:
URL: https://github.com/apache/maven-build-cache-extension/pull/209
```MojoParametersListener#beforeMojoExecution``` only needs to set
projectExecutions when ```source == Source.LIFECYCLE && !forkedExecution``` is
true, the most appropriate way to handle it is adding field cacheState to
MojoParametersListener and setting it's value by
```BuildCacheMojosExecutionStrategy```.
@olamy
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [MBUILDCACHE JIRA
issue](https://issues.apache.org/jira/browse/MBUILDCACHE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MBUILDCACHE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MBUILDCACHE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> do not set projectExecutions if cacheState is disabled
> -------------------------------------------------------
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Yu Yu
> Assignee: Olivier Lamy
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.3.0
>
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
