[
https://issues.apache.org/jira/browse/MBUILDCACHE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Yu updated MBUILDCACHE-123:
------------------------------
Description:
Revised content:
# modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got cacheState
and don't allocate projectExecutions memory if cacheState is disabled.
# added sisu-maven-plugin to pom.xml for generating
{{META-INF/sisu/javax.inject.Named}} which should be included in the maven
extension jar.
Cause:
if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
MojoParametersListener will always allocate memory for saving projectExecutions
even disable the cache by {{-Dmaven.build.cache.enabled=false}}
[!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
this pr is related to
[apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
was:
Revised content:
# modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got cacheState
and don't allocate projectExecutions memory if cacheState is disabled.
# added sisu-maven-plugin to pom.xml for generating
{{META-INF/sisu/javax.inject.Named}} which should be included in the maven
extension jar.
Cause:
if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
MojoParametersListener will always allocate memory for saving projectExecutions
even disable the cache by {{-Dmaven.build.cache.enabled=false}}
[!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
i will modify the pr title after i could submit an issue for this pr, i don't
have jira account yet (already send request).
this pr is related to
[apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
> do not set projectExecutions if cacheState is disabled
> -------------------------------------------------------
>
> Key: MBUILDCACHE-123
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-123
> Project: Maven Build Cache Extension
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Yu Yu
> Priority: Major
>
> Revised content:
> # modified {{{}MojoParametersListener#beforeMojoExecution{}}}: got
> cacheState and don't allocate projectExecutions memory if cacheState is
> disabled.
> # added sisu-maven-plugin to pom.xml for generating
> {{META-INF/sisu/javax.inject.Named}} which should be included in the maven
> extension jar.
> Cause:
> if set maven-build-cache-extension at {{{}.mvn/extensions.xml{}}},
> MojoParametersListener will always allocate memory for saving
> projectExecutions even disable the cache by
> {{-Dmaven.build.cache.enabled=false}}
> [!https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY!|https://private-user-images.githubusercontent.com/40652892/436356636-7ab0c63a-cab5-47fb-9bdc-2b4cc2756b55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDU1MDIyMDAsIm5iZiI6MTc0NTUwMTkwMCwicGF0aCI6Ii80MDY1Mjg5Mi80MzYzNTY2MzYtN2FiMGM2M2EtY2FiNS00N2ZiLTliZGMtMmI0Y2MyNzU2YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDI0VDEzMzgyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQzZmM5MzhhNDEwYWZiNDgyZjdiZGQzNjUyOWQ0MTdmMjZhNjNiZWRiYmQ0M2Y3YTdlNDc3OWMzZDY5MWY0NDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CEjx6ZBw4UHYjNnpUSCbpKBrvwgNtnktSGOY2u7z4hY]
> this pr is related to
> [apache/dubbo#15328|https://github.com/apache/dubbo/issues/15328]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
