[ https://issues.apache.org/jira/browse/MPMD-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945884#comment-17945884 ]
ASF GitHub Bot commented on MPMD-412: ------------------------------------- Bukama commented on PR #190: URL: https://github.com/apache/maven-pmd-plugin/pull/190#issuecomment-2816827270 > Interesting. Passed on the CI though. I wonder if that test is flaky? No it's not compatible with Maven 4. > 'repositories.repository.[corp1].url' contains an unsupported expression (only expressions starting with 'project.basedir' or 'project.rootDirectory' are supported). The `project.rootDirectory` property only exists in Maven 4. So the IT's repository definition using `${user.dir}` is not compatible with Maven 4: ```xml <repositories> <repository> <id>corp1</id> <url>file://${user.dir}/private-repo</url> </repository> </repositories> ``` Just tested it with Maven 3 and it's okay ``` D:\Github\Maven\maven-pmd-plugin>mvn clean verify -P run-its -V Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256) Maven home: C:\apache-maven-3.9.8 Java version: 21.0.1, vendor: Eclipse Adoptium, runtime: C:\JDK\Java21 Default locale: de_DE, platform encoding: UTF-8 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" [...] [INFO] Build Summary: [INFO] Passed: 46, Failed: 0, Errors: 0, Skipped: 4 [INFO] ------------------------------------------------- [WARNING] The following builds were skipped: [WARNING] * MPMD-304-toolchain-support\pom.xml [WARNING] * MPMD-348-JDK19\pom.xml [WARNING] * MPMD-365-JDK20\pom.xml [WARNING] * MPMD-379-JDK21\pom.xml [INFO] ------------------------------------------------- [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 04:40 min [INFO] Finished at: 2025-04-19T20:57:10+02:00 [INFO] ------------------------------------------------------------------------ ``` > Tests are inobviously broken due to overly broad catch clauses > -------------------------------------------------------------- > > Key: MPMD-412 > URL: https://issues.apache.org/jira/browse/MPMD-412 > Project: Maven PMD Plugin > Issue Type: Bug > Reporter: Elliotte Rusty Harold > Priority: Blocker > > See https://github.com/apache/maven-pmd-plugin/pull/178 > We're catching java.lang.Exception and thus often missing that the wrong > exception is being caught, and that the test is in fact failing. -- This message was sent by Atlassian Jira (v8.20.10#820010)