jira-importer commented on issue #548: URL: https://github.com/apache/maven-deploy-plugin/issues/548#issuecomment-2771550841
**[Phil Clay](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=philsttr)** commented Hi [Michael Osipov](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michael-o). Thank you for the response! It looks like the only recent changes to this area are to add a more descriptive error message in https://github.com/apache/maven-deploy-plugin/pull/12. Unfortunately, that change doesn't solve the problem for which I originally filed this ticket. I would like for the `alt*DeploymentRepository` properties to maintain support for `id::default::url` format if and only if the layout is equal to "default". Making this backwards compatible will allow maven settings files on CI servers to specify the `alt*DeploymentRepository` properties regardless of the version of the maven-deploy-plugin used by the hundreds of projects being built by that CI server. With the recent changes, the [regex](https://github.com/apache/maven-deploy-plugin/blob/92d7e747c2228ed411ae6e9d1639401a6b8fe6cc/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java#L54) for detecting the old format and [checking for layout == "default"](https://github.com/apache/maven-deploy-plugin/blob/92d7e747c2228ed411ae6e9d1639401a6b8fe6cc/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java#L260) has been re-introduced for the purpose of modifying an error message. Since the code is already parsing the string, and checking for layout == "default", it would be trivial to continue to support the legacy format if the layout is "default" by changing the code [here](https://github.com/apache/maven-deploy-plugin/blob/92d7e747c2228ed411ae6e9d1639401a6b8fe6cc/src/main/java/org/apache/maven/plugins/deploy/DeployMojo.java#L262) to output a warning message, instead of throwing an error. I have submitted https://github.com/apache/maven-deploy-plugin/pull/15 to do so. Please do consider merging the PR to make this backwards compatible to reduce the pain when upgrading the maven-deploy-plugin for projects that use common maven settings files that specify the `alt*DeploymentRepository` properties. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
