[
https://issues.apache.org/jira/browse/MDEPLOY-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774563#comment-17774563
]
ASF GitHub Bot commented on MDEPLOY-312:
----------------------------------------
jaredstehler opened a new pull request, #44:
URL: https://github.com/apache/maven-deploy-plugin/pull/44
This merges resolved snapshot version for deployed artifacts back into the
maven project model, for use in downstream plugins, which is how the plugin
worked prior to 3.0.0.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MDEPLOY) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MDEPLOY-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MDEPLOY-XXX` with the appropriate JIRA issue. Best
practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> [REGRESSION] deploy no longer updates project model
> ---------------------------------------------------
>
> Key: MDEPLOY-312
> URL: https://issues.apache.org/jira/browse/MDEPLOY-312
> Project: Maven Deploy Plugin
> Issue Type: Bug
> Components: deploy:deploy, deploy:deploy-file
> Affects Versions: 3.0.0
> Reporter: Jared Stehler
> Priority: Major
>
> Prior to 3.0.0, the maven-deploy-plugin would update artifacts on the Project
> model:
> *
> [https://github.com/apache/maven/blob/master/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java#L147]
> *
> [https://github.com/apache/maven-deploy-plugin/blob/maven-deploy-plugin-2.8.2/src/main/java/org/apache/maven/plugin/deploy/DeployFileMojo.java#L276]
> This is no longer occurring with the migration to maven-resolver, which is
> breaking our downstream plugins relying on the resolved SNAPSHOT version.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
