timtebeek commented on code in PR #58:
URL:
https://github.com/apache/maven-install-plugin/pull/58#discussion_r1212983344
##########
src/main/java/org/apache/maven/plugins/install/InstallFileMojo.java:
##########
@@ -218,7 +218,7 @@ public void execute() throws MojoExecutionException,
MojoFailureException {
ArtifactType artifactType =
repositorySystemSession.getArtifactTypeRegistry().get(packaging);
if (artifactType != null
- && StringUtils.isEmpty(classifier)
+ && (classifier == null || classifier.isEmpty())
&& !StringUtils.isEmpty(artifactType.getClassifier())) {
Review Comment:
Looking at this again: the line was not missed, but intentionally left out
in the recipe, as we can't be certain that the argument method invocation is
safe to call twice; once for the null check, and again for the isEmpty call.
Hence why I don't convert those automatically yet, even though in this case
it's probably safe to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
