[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724850#comment-17724850
]
ASF GitHub Bot commented on MNG-6829:
-------------------------------------
timtebeek commented on code in PR #272:
URL: https://github.com/apache/maven-enforcer/pull/272#discussion_r1200257124
##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/BannedRepositories.java:
##########
@@ -91,7 +90,7 @@ public void execute() throws EnforcerRuleException {
String errMsg = repoErrMsg + pluginRepoErrMsg;
- if (errMsg != null && !StringUtils.isEmpty(errMsg)) {
+ if (errMsg != null && !(errMsg == null || errMsg.isEmpty())) {
Review Comment:
Yes thanks! Applied just now.
We're looking to [add nullability to our type
system](https://github.com/openrewrite/rewrite/issues/3221), such that we no
longer add duplicate null checks where they are not necessary, and clean them
up with a subsequent recipe.
In addition to that there's unfortunately some not-ideal use of
`!StringUtils.isEmpty()` instead of `StringUtils.isNotEmpty()`; we've discussed
whether to tackle that separately first, but as we're phasing these calls out
we decided against that for now. Nearly there. :)
> Remove commons-lang3 dependency
> -------------------------------
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
