elharo commented on code in PR #185:
URL: https://github.com/apache/maven-release/pull/185#discussion_r1188960087
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java:
##########
@@ -79,7 +79,7 @@ private ReleaseResult runLogic(
// ensure we don't use the release pom for the perform goals
// ^^ paranoia? A MavenExecutor has already access to this. Probably
worth refactoring.
- if (!StringUtils.isEmpty(additionalArguments)) {
+ if (!(additionalArguments == null || additionalArguments.isEmpty())) {
Review Comment:
The recipe could be updated to rewrite this one as
```
additionalArguments != null && !additionalArguments.isEmpty()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
