MartinKanters commented on code in PR #869:
URL: https://github.com/apache/maven/pull/869#discussion_r1180163974
##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -444,10 +447,10 @@ private CommandLine cliMerge(CommandLine mavenConfig,
CommandLine mavenCli) {
*/
void logging(CliRequest cliRequest) {
// LOG LEVEL
- cliRequest.verbose =
cliRequest.commandLine.hasOption(CLIManager.VERBOSE)
- || cliRequest.commandLine.hasOption(CLIManager.DEBUG);
- cliRequest.quiet = !cliRequest.verbose &&
cliRequest.commandLine.hasOption(CLIManager.QUIET);
- cliRequest.showErrors = cliRequest.verbose ||
cliRequest.commandLine.hasOption(CLIManager.ERRORS);
+ CommandLine commandLine = cliRequest.commandLine;
+ cliRequest.verbose = commandLine.hasOption(CLIManager.VERBOSE) ||
commandLine.hasOption(CLIManager.DEBUG);
Review Comment:
Hmm, I think it's a nice improvement, but since it's just formatting
related, I would rather just ship it with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
