michael-o commented on code in PR #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r1172989881


##########
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt:
##########
@@ -826,12 +826,14 @@ Introduction to the Dependency Mechanism
 
  <<<Important note: This is deprecated.>>>
 
- Dependencies with the scope <system> are always available and are not looked
- up in repository. They are usually used to tell Maven about dependencies which
- are provided by the JDK or the VM. Thus, system dependencies are especially
- useful for resolving dependencies on artifacts which are now provided by the
- JDK, but were available as separate downloads earlier. Typical examples are
- the JDBC standard extensions or the Java Authentication and Authorization
+ Dependencies with the scope <system> are not looked up in the Maven 
repository system.
+ Instead the `dependency` element contains a `systemPath` pointing to a jar on 
the local
+ file system.
+ 
+ The system scope is commonly used to tell Maven about dependencies provided 
by the JDK or the VM. 
+ System dependencies are especially useful for resolving dependencies on 
artifacts which
+ are now provided by the JDK, but were available as separate downloads 
earlier. Typical
+ examples are the JDBC standard extensions or the Java Authentication and 
Authorization

Review Comment:
   I don't even know whether the cae with JDBC and JAAS is still true. I'd try 
to avoid giving example which are invalid in a couple of years.



##########
pom.xml:
##########
@@ -55,7 +55,8 @@
 
   <properties>
     <maven.site.path>maven-site</maven.site.path>
-    <project.build.outputTimestamp>x</project.build.outputTimestamp><!-- 
disable Reproducible Builds that makes the site build time fixed at last 
release time -->

Review Comment:
   Unrelated change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to